Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSN-46] - Changed primary key setvalue #18

Merged
merged 3 commits into from
May 9, 2024
Merged

[RSN-46] - Changed primary key setvalue #18

merged 3 commits into from
May 9, 2024

Conversation

bilimig
Copy link
Collaborator

@bilimig bilimig commented Apr 29, 2024

Description

Setting primary key setvalue to max value of id in tables.

Motivation

Related issue and/or ticket

RSN-46

@bilimig bilimig added scope: database Indicates that PR relates to database changes. type: feature PR's categorised as feature. labels Apr 29, 2024
@bilimig bilimig requested review from raczu and wzarek April 29, 2024 18:15
@bilimig bilimig self-assigned this Apr 29, 2024
@bilimig bilimig added the status: ready for review Determines that PR is ready for review. label Apr 29, 2024
Copy link
Collaborator

@raczu raczu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initializing the test data does not work, as there is an error in the sql file responsible for initalizing the database itself, so I assume usage of setval function has not been even tested - please fix this error and then test if indexes are properly set for further data.

Database/init-dev-data.sql Outdated Show resolved Hide resolved
@wzarek wzarek added status: require changes Determines that PR requires changes to be approved. and removed status: ready for review Determines that PR is ready for review. labels May 3, 2024
@wzarek wzarek changed the title RSN-46 Changed primary key setvalue to 10 [RSN-46] - Changed primary key setvalue to 10 May 6, 2024
@bilimig bilimig requested a review from raczu May 7, 2024 21:45
@bilimig bilimig added status: ready for review Determines that PR is ready for review. status: require changes Determines that PR requires changes to be approved. and removed status: require changes Determines that PR requires changes to be approved. status: ready for review Determines that PR is ready for review. labels May 7, 2024
@bilimig bilimig added status: require changes Determines that PR requires changes to be approved. and removed status: ready for review Determines that PR is ready for review. labels May 8, 2024
@bilimig bilimig changed the title [RSN-46] - Changed primary key setvalue to 10 [RSN-46] - Changed primary key setvalue May 9, 2024
@bilimig bilimig added status: ready for review Determines that PR is ready for review. and removed status: require changes Determines that PR requires changes to be approved. labels May 9, 2024
Copy link
Owner

@wzarek wzarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@bilimig bilimig merged commit 82b1862 into main May 9, 2024
7 checks passed
@bilimig bilimig deleted the RSN-46 branch May 9, 2024 12:18
rogacky11 pushed a commit that referenced this pull request May 17, 2024
* Changed primary key setvalue to 10

* Update init-dev-data.sql

* Added setval to init-db
rogacky11 pushed a commit that referenced this pull request May 17, 2024
* Changed primary key setvalue to 10

* Update init-dev-data.sql

* Added setval to init-db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: database Indicates that PR relates to database changes. status: ready for review Determines that PR is ready for review. type: feature PR's categorised as feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants