[RSN-38] - Create services (address, comment, objecttype, participant, role, user*) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoper02
added
scope: backend
raczu
requested changes
May 4, 2024
wzarek
added
status: require changes
…based on PR review
mkoper02
added
status: ready for review
|
@mkoper02 please first merge main into RSN-14 in order to not have this long list of commits from main, I assume you didn't modified 117 files :) |
wzarek
added
status: require changes
wzarek
changed the title
wzarek
added
status: require changes
wzarek
added
status: ready for review
wzarek
requested changes
Jun 6, 2024
|
|
||
| context.Users.Update(user); | ||
|
|
||
| if (userDto.Interests is null || userDto.Interests.Count == 0) |
There was a problem hiding this comment.
Suggested change
| if (userDto.Interests is null || userDto.Interests.Count == 0) | |
| if (userDto.Interests is null || !userDto.Interests.Any()) | |
There was a problem hiding this comment.
Visual Studio suggest to leave it as it is for clarity. I also think .Count == 0 is easier to read.
Services now throw errors if something is not right (dto null, data not found in db), updated unit tests and created custom exception classes
raczu
requested changes
Jun 8, 2024
wzarek
added
status: require changes
mkoper02
added
status: ready for review
raczu
approved these changes
Jun 8, 2024
wzarek
reviewed
Jun 9, 2024
There was a problem hiding this comment.
One thing - if Dawid created folder in root dir of ReasnAPI of 'Exceptions' then I think we can stick to that and have ReasnAPI/Exceptions not ReasnAPI/**/Exceptions, we may then split those exceptions into different subfolders, right - but think having them in one place could be benefitial
mkoper02
added a commit
that referenced
this pull request
Jun 18, 2024
…, role, user*) (#19) * Created services classes and added TODO methods for each class * Created basic CRUD methods * Changed methods returing types, checks for null * Checks if user already exists in db etc., created tests for services * Fixed unit test * Changed type taken by the services, new, improved tests for services * Final fixes and changed unit tests for methods with foreign keys * Changed delete method to return bool, fixed typos and other problems based on PR review * Added brackets one line ifs and added delete method for ObjectTypeService * Revert "Added brackets to one line ifs, updated delete method in ObjectTypeService" This reverts commit 1c69f11, reversing changes made to 1a58a27. * Created services classes and added TODO methods for each class * Created basic CRUD methods * Changed methods returing types, checks for null * Checks if user already exists in db etc., created tests for services * Fixed unit test * Changed type taken by the services, new, improved tests for services * Final fixes and changed unit tests for methods with foreign keys * Changed delete method to return bool, fixed typos and other problems based on PR review * Added brackets one line ifs and added delete method for ObjectTypeService * Updated services after scaffold Updated services and tests, User service not finished, enums not working * Workflow fixes * Unit test fix * Working user service * Deleted test controller * Transaction for user update service * Updated services and created mappers * Services throw errors Services now throw errors if something is not right (dto null, data not found in db), updated unit tests and created custom exception classes * Mappers function name change * Update based on review * Added GetUserByUsername function * Changed exceptions directory location
mkoper02
added a commit
that referenced
this pull request
Jun 19, 2024
* Created services classes and added TODO methods for each class * [RSN-38] - Create services (address, comment, objecttype, participant, role, user*) (#19) * Created services classes and added TODO methods for each class * Created basic CRUD methods * Changed methods returing types, checks for null * Checks if user already exists in db etc., created tests for services * Fixed unit test * Changed type taken by the services, new, improved tests for services * Final fixes and changed unit tests for methods with foreign keys * Changed delete method to return bool, fixed typos and other problems based on PR review * Added brackets one line ifs and added delete method for ObjectTypeService * Revert "Added brackets to one line ifs, updated delete method in ObjectTypeService" This reverts commit 1c69f11, reversing changes made to 1a58a27. * Created services classes and added TODO methods for each class * Created basic CRUD methods * Changed methods returing types, checks for null * Checks if user already exists in db etc., created tests for services * Fixed unit test * Changed type taken by the services, new, improved tests for services * Final fixes and changed unit tests for methods with foreign keys * Changed delete method to return bool, fixed typos and other problems based on PR review * Added brackets one line ifs and added delete method for ObjectTypeService * Updated services after scaffold Updated services and tests, User service not finished, enums not working * Workflow fixes * Unit test fix * Working user service * Deleted test controller * Transaction for user update service * Updated services and created mappers * Services throw errors Services now throw errors if something is not right (dto null, data not found in db), updated unit tests and created custom exception classes * Mappers function name change * Update based on review * Added GetUserByUsername function * Changed exceptions directory location * [RSN-37] - Created services for Event Tag Parameter Interest Image (#42) * Created CRUD services for Parameter, Status, Tag and C&U for Event * created CRUD Image, Interest, Event and Parameter Services Also added geting all elements and by filter(not done properly yet) * changed delete services to void isnted of bool * Fixed GetByFilter service in Event, Image, Intrest, Parameter, Status and Tag Services * little changes * fixing build issue and changing list to ienumerable * Fixing EventServices and standardizing syntax issues * created test for interest status parameter and tag * Created ImageServicesTests * Updated Parameter, Tag, Status services Checked if any of Parameters, Tags or Statuses are used before delating/updating. * fixed bug in imageservicetest * one more fix * Updated services and tests Changed delete methods to bool, updated mocks on tests. * Updated services * Updates after scafoled nr 1 * Updated services Changed using bridge tables to using colections in EF. * Updated EventService added a logic for parameters in event * working event services * created mappers and small fixes * finished mappers * Added exceptions in services * fixed mappers according to our convension * Changed exceptions directory location * fixed build error * Exceptions changes * Unit tests fix * updated services * Slug creating method updated * Update ImageService.cs * Update ImageService.cs * updated image services and tests also updated slug method for event services * event service delete method updated * refactor and fixes * refactor * Update EventService.cs * last refactor * removing spaces * added geteventbyslug method to eventservice * Update ImageService.cs * refactor * changed list to Enumerable * changed list to enumerable * folder refactor * updated services * Update EventService.cs * changes * Update EventServicesTest.cs * updates * Update EventService.cs * Update EventService.cs * Update ImageService.cs * Updates * Update EventMapper.cs * changes * Update ImageServiceTests.cs * changes * Formating * Update EventService.cs * Update EventService.cs * changes * Created AddEventComment method * Update EventService.cs * fixed updating and creating event * Update EventService.cs * changed create slug and text for event --------- Co-authored-by: Maciej Koperdowski <[email protected]> * Update Entity Framework version * Changed exceptions location * ReasnContext update --------- Co-authored-by: Owczarek Kamil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created CRUD operations and Unit Tests for given services:
* UserServices are not finished - still waiting for scaffold.