Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSN-10 Create DTOs #3

Merged
merged 5 commits into from
Mar 25, 2024
Merged

RSN-10 Create DTOs #3

merged 5 commits into from
Mar 25, 2024

Conversation

mkoper02
Copy link
Collaborator

No description provided.

@raczu raczu added scope: backend Indicates that PR relates to backend changes. type: feature PR's categorised as feature. labels Mar 24, 2024
Server/ReasnAPI/ReasnAPI/Models/DTO/CommentDto.cs Outdated Show resolved Hide resolved
Server/ReasnAPI/ReasnAPI/Models/DTO/EventDto.cs Outdated Show resolved Hide resolved
Server/ReasnAPI/ReasnAPI/Models/DTO/ParticipantDto.cs Outdated Show resolved Hide resolved
Server/ReasnAPI/ReasnAPI/Models/DTO/UserDto.cs Outdated Show resolved Hide resolved
Server/ReasnAPI/ReasnAPI/Models/DTO/EventDto.cs Outdated Show resolved Hide resolved
@wzarek wzarek added the status: require changes Determines that PR requires changes to be approved. label Mar 24, 2024
@mkoper02
Copy link
Collaborator Author

As suggested, I changed the following things:

  • Name of the Created parameter to CreatedAt in CommentDto class,
  • Fixed spelling in class ParticipantDto,
  • Added UpdatedAt and CreatedAt in EventDto class,
  • For UserDto class I changed parameter Address (AddressDto type) to AddressId (int) and added list of intrests.

@mkoper02 mkoper02 requested a review from wzarek March 24, 2024 18:13
@wzarek wzarek added status: ready for review Determines that PR is ready for review. and removed status: require changes Determines that PR requires changes to be approved. labels Mar 24, 2024
Server/ReasnAPI/ReasnAPI/Models/DTO/AddressDto.cs Outdated Show resolved Hide resolved
Server/ReasnAPI/ReasnAPI/Models/DTO/EventDto.cs Outdated Show resolved Hide resolved
Server/ReasnAPI/ReasnAPI/Models/DTO/StatusDto.cs Outdated Show resolved Hide resolved
@wzarek wzarek added status: require changes Determines that PR requires changes to be approved. and removed status: ready for review Determines that PR is ready for review. labels Mar 24, 2024
@mkoper02
Copy link
Collaborator Author

mkoper02 commented Mar 24, 2024

Next changes:

  • Created new DTOs - RoleDto and TagDto,
  • Added list of tags in EventDto,
  • Changed State parameter from nullable to non-nullable in AddressDto.

@mkoper02 mkoper02 added status: ready for review Determines that PR is ready for review. and removed status: require changes Determines that PR requires changes to be approved. labels Mar 24, 2024
@mkoper02 mkoper02 requested a review from wzarek March 24, 2024 20:46
@wzarek wzarek added status:+require+changes status: require changes Determines that PR requires changes to be approved. status: ready for review Determines that PR is ready for review. and removed status: ready for review Determines that PR is ready for review. status:+require+changes status: require changes Determines that PR requires changes to be approved. labels Mar 24, 2024
@wzarek wzarek added status: require changes Determines that PR requires changes to be approved. status: ready for review Determines that PR is ready for review. and removed status%3A%20require%20changes status: ready for review Determines that PR is ready for review. status: require changes Determines that PR requires changes to be approved. labels Mar 25, 2024
Copy link
Owner

@wzarek wzarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but having in mind naming conventions in C#, especially this one:

CONSIDER using plural namespace names where appropriate.

For example, use System.Collections instead of System.Collection. Brand names and acronyms are exceptions to this rule, however. For example, use System.IO instead of System.IOs.
~ from Names of Namespaces

I think it is more appropriate to use plural form since we can easily create a plural form from DTO and it will be Data Transfer Objects.
If you have any objections - let's discuss it :)

@wzarek wzarek added status: require changes Determines that PR requires changes to be approved. and removed status: ready for review Determines that PR is ready for review. labels Mar 25, 2024
@mkoper02 mkoper02 added status: ready for review Determines that PR is ready for review. and removed status: require changes Determines that PR requires changes to be approved. labels Mar 25, 2024
@mkoper02 mkoper02 requested a review from wzarek March 25, 2024 10:19
Copy link
Owner

@wzarek wzarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK

@mkoper02 mkoper02 merged commit eb861a0 into main Mar 25, 2024
1 check passed
@mkoper02 mkoper02 deleted the RSN-10 branch March 25, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: backend Indicates that PR relates to backend changes. status: ready for review Determines that PR is ready for review. type: feature PR's categorised as feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants