Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSN-53] Add pre-commit hook to run fmt and lint #44

Merged
merged 5 commits into from
Jun 5, 2024
Merged

[RSN-53] Add pre-commit hook to run fmt and lint #44

merged 5 commits into from
Jun 5, 2024

Conversation

raczu
Copy link
Collaborator

@raczu raczu commented Jun 2, 2024

Description

Add pre-commit hook to format and lint code on each format - used for this husky. Getting the hook to properly requires installing yarn and executing following commands:

cd Client/reasn-client
yarn install && yarn postinstall

After exceuting these commands, the hooks should be installed correctly, and on each commit, the appropriate actions will be performed.

Related issue and/or ticket

RSN-53

@raczu raczu added scope: ci/cd Indicates that PR relates to workflows changes. type: feature PR's categorised as feature. status: ready for review Determines that PR is ready for review. labels Jun 2, 2024
@raczu raczu requested a review from wzarek June 2, 2024 19:37
@raczu
Copy link
Collaborator Author

raczu commented Jun 2, 2024

@wzarek

Copy link
Owner

@wzarek wzarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Interest, Role and Status DTO? They were removed earlier from what I see

@wzarek wzarek added status: require changes Determines that PR requires changes to be approved. status: ready for review Determines that PR is ready for review. and removed status: ready for review Determines that PR is ready for review. status: require changes Determines that PR requires changes to be approved. labels Jun 3, 2024
@raczu
Copy link
Collaborator Author

raczu commented Jun 3, 2024

What about Interest, Role and Status DTO? They were removed earlier from what I see

I had missed it when rebasing and unnecessary added them, they are now removed.

Copy link
Owner

@wzarek wzarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wzarek wzarek merged commit d814d53 into main Jun 5, 2024
7 checks passed
@wzarek wzarek deleted the RSN-53 branch June 5, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: ci/cd Indicates that PR relates to workflows changes. status: ready for review Determines that PR is ready for review. type: feature PR's categorised as feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants