-
Notifications
You must be signed in to change notification settings - Fork 21
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Address some points raised in review
* the i18n data attributes should really be used for localisation, they're now Italian (thanks @edujackedu!) * the official component is called 'password input' rather than 'password field'. I've changed this around in the guide but left the actual code as #govuk_password_field so it's consistent with Rails' other form helpers * renamed the example attributes from PIN and secret code to password_1, password_2, password_3. They need to be unique and not encourage people to use this component for things other than passwords
- Loading branch information
1 parent
d316ce7
commit 507a0d1
Showing
4 changed files
with
20 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters