Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove guide hover colour override #474

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

peteryates
Copy link
Member

@peteryates peteryates commented Feb 3, 2024

The only place I can see it have an impact is on small radios and the dark blue looks a bit odd.

Here is the Design System on the left and the guide on the right before the change:

Screenshot from 2024-02-03 19-47-58

After the change they'll look the same. Not sure what else this affects though! 🙈

Copy link

netlify bot commented Feb 3, 2024

Deploy Preview for govuk-form-builder ready!

Name Link
🔨 Latest commit 8154201
🔍 Latest deploy log https://app.netlify.com/sites/govuk-form-builder/deploys/65bfd136807a8b00077479eb
😎 Deploy Preview https://deploy-preview-474--govuk-form-builder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@paulrobertlloyd paulrobertlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; added correct SCSS variables.

guide/content/stylesheets/application.scss Outdated Show resolved Hide resolved
Co-authored-by: Paul Robert Lloyd <[email protected]>
@peteryates peteryates merged commit dfd05b7 into main Feb 4, 2024
17 checks passed
@peteryates peteryates deleted the fix-guide-hover-colour branch February 4, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants