Standalone labels #514
Merged
Standalone labels #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for govuk-form-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This simply exposes GOVUKDesignSystemFormBuilder::Elements::Label via a new `#govuk_label` method on the builder object. It is intended to be used on occasions where the label isn't wanted immediately above the input, such as in a table. Fixes #480
This is quite an advanced use which will stretch the Design System to the limit. HTML has long-supported placing labels far from the corresponding input, even outside the form altogether. The risk here is that error messages now will be placed by the input, which has a strong likelihood of breaking layouts. Still, I'm sure some people will find a use for this. Fixes #477
peteryates
force-pushed
the
standalone-labels
branch
from
58dd55e
to
298d836
Compare
| subject { builder.send(*args, **kwargs) } | ||
|
|
||
| specify 'renders a label with the right custom text' do | ||
| expect(subject).to have_tag('label', text: custom_label_text, with: { class: 'govuk-label' }) |
There was a problem hiding this comment.
Worth adding a test for the for attribute too, given that this will be needed to link the label to the input?
There was a problem hiding this comment.
Missed this, but yeah it is. Will add it.
frankieroberto
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes
GOVUKDesignSystemFormBuilder::Elements::Labeldirectly via#govuk_label. It's intended to allow authors to place the label somewhere other than immediately above the input.Its usage isn't covered by the design system so comes with the risk that the error message will still be rendered next to the input which will likely break layouts when used in confined spaces (i.e., table cells)
The regular label arguments will still work so authors can customise the label's: