Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sass settings #789

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Update Sass settings #789

merged 4 commits into from
Feb 5, 2024

Conversation

paulrobertlloyd
Copy link
Collaborator

  • Use new X-GOVUK link state colours
  • Remove deprecated $govuk-new-link-styles setting (deprecated in GOV.UK Frontend v5.0)
  • Remove unused .app-width-container rule (pretty sure this was copied over from the stylesheet for GOV.UK Components)
  • Remove _logo.scss as it contains a duplicate .app-header__logo rule

@paulrobertlloyd paulrobertlloyd changed the title Sass settings Update Sass settings Feb 5, 2024
frankieroberto
frankieroberto approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frankieroberto frankieroberto merged commit d6b0f6f into main Feb 5, 2024
1 check passed
@frankieroberto frankieroberto deleted the sass-settings branch February 5, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankieroberto frankieroberto frankieroberto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulrobertlloyd @frankieroberto