Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Effects to Temp for NAS #5079

Conversation

cybercop23
Copy link
Collaborator

When rgbeffects is on a NAS and we save a new version, because of the line by line save, it takes a very long time to save. Saving it to the local OS temp folder and then renaming it to the show folder, seems to address this slowwwwwnesssss

@tgrinnall
Copy link

this fixed the 4 min save time for my nas now it only take 2 sec. thanks

@computergeek1507
Copy link
Member

Not a huge fan of slowing down saving for 99% of users to help 1%

@cybercop23
Copy link
Collaborator Author

For local disk savings is <1 sec.

@computergeek1507
Copy link
Member

With 2000+ models?

@cybercop23
Copy link
Collaborator Author

Than you are the other 3% with a commercial show.

@computergeek1507
Copy link
Member

computergeek1507 commented Dec 27, 2024

I don't know the wx xml library very well but I assume it could be generated in memory and then saved to disk

@cybercop23
Copy link
Collaborator Author

I was thinking the same, but since it was never used, figured it didn't exist. I know we talked about several perofrmance enhancements with the move to QT... maybe start now

@dkulp
Copy link
Member

dkulp commented Dec 31, 2024

Updated the save routine to use a wxBufferedOutputStream which keeps it from writing temp files and should fix this.

@dkulp dkulp closed this Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants