CP-46777: don't issue new requests if there are failed to retry #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are requests queued in the failed_requests list to be retried don't issue any new ones. Signed-off-by: Mark Syms <[email protected]>
TimSmithCtx
approved these changes
Nov 27, 2023
KevinLCtx
approved these changes
Nov 27, 2023
| @@ -1654,6 +1654,10 @@ tapdisk_vbd_issue_new_requests(td_vbd_t *vbd) | |||
| int err; | |||
| td_vbd_request_t *vreq, *tmp; | |||
|
|
|||
| if (!list_empty(&vbd->failed_requests)) { | |||
| return -EBUSY; | |||
There was a problem hiding this comment.
Just trying to follow the logic here... if we return -EBUSY here, this will cause tapdisk_server_recheck_vbds() to return 0 (assuming there is only a single vbd) which will cause tapdisk_server_iterate() to go back and wait for events.
At that point, the only thing that will cause tapdisk to wake up and submit the new requests is if one of the failed requests completes or times out. Is that correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are requests queued in the failed_requests list to be retried don't issue any new ones.