-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-51988: Fix functions not work for remote_pool repo #6095
Merged
BengangY
merged 2 commits into
xapi-project:feature/easier-pool-join
from
BengangY:private/bengangy/CP-51988
Nov 8, 2024
Merged
CP-51988: Fix functions not work for remote_pool repo #6095
BengangY
merged 2 commits into
xapi-project:feature/easier-pool-join
from
BengangY:private/bengangy/CP-51988
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangj
reviewed
Oct 31, 2024
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
from
October 31, 2024 10:07
a76de9a
to
615326d
Compare
gangj
approved these changes
Oct 31, 2024
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
from
October 31, 2024 13:45
615326d
to
a76cebb
Compare
lindig
reviewed
Oct 31, 2024
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
from
November 1, 2024 03:56
a76cebb
to
340d27f
Compare
gangj
reviewed
Nov 1, 2024
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
from
November 4, 2024 02:57
340d27f
to
170c700
Compare
gangj
reviewed
Nov 4, 2024
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
from
November 4, 2024 07:59
170c700
to
ab89079
Compare
Java SDK build failed on:
Consider change the name "repo-type" to "repo_type" ? |
gangj
reviewed
Nov 4, 2024
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
from
November 4, 2024 12:51
ab89079
to
48f640f
Compare
Updated to "repo_type" and it passed now. |
lindig
approved these changes
Nov 4, 2024
gangj
reviewed
Nov 5, 2024
gangj
reviewed
Nov 5, 2024
gangj
reviewed
Nov 5, 2024
gangj
reviewed
Nov 5, 2024
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
2 times, most recently
from
November 6, 2024 10:29
98e7102
to
a2a7936
Compare
robhoes
reviewed
Nov 6, 2024
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
from
November 6, 2024 13:32
a2a7936
to
4dfe922
Compare
gangj
reviewed
Nov 6, 2024
gangj
reviewed
Nov 6, 2024
gangj
reviewed
Nov 6, 2024
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
from
November 7, 2024 01:38
4dfe922
to
623e8d0
Compare
gangj
reviewed
Nov 7, 2024
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
from
November 8, 2024 09:58
623e8d0
to
1ef3ae7
Compare
1. `remote_pool` repo doesn't support periodic sync updates. 2. Periodic sync updates should be auto-disabled when calling `set_repositories` and `add_repository` for `remote_pool` repo. 3. If `remote_pool` repository is enabled, it should be the single one enabled. Signed-off-by: Bengang Yuan <[email protected]>
Signed-off-by: Bengang Yuan <[email protected]>
BengangY
force-pushed
the
private/bengangy/CP-51988
branch
from
November 8, 2024 10:01
1ef3ae7
to
29e1fe4
Compare
gangj
approved these changes
Nov 8, 2024
BengangY
merged commit Nov 8, 2024
deb25d2
into
xapi-project:feature/easier-pool-join
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote_pool
repo doesn't support periodic sync updates.set_repositories
andadd_repository
forremote_pool
repo.