Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-51988: Fix functions not work for remote_pool repo #6095

Conversation

BengangY
Copy link
Contributor

@BengangY BengangY commented Oct 30, 2024

  1. remote_pool repo doesn't support periodic sync updates.
  2. Periodic sync updates should be auto-disabled when calling set_repositories and add_repository for remote_pool repo.
  3. Update UT.

@BengangY BengangY marked this pull request as ready for review October 30, 2024 09:46
ocaml/xapi/xapi_pool.ml Outdated Show resolved Hide resolved
ocaml/idl/datamodel_errors.ml Outdated Show resolved Hide resolved
ocaml/idl/datamodel_errors.ml Outdated Show resolved Hide resolved
ocaml/xapi/xapi_pool.ml Outdated Show resolved Hide resolved
ocaml/idl/datamodel_errors.ml Outdated Show resolved Hide resolved
@xueqingz
Copy link
Contributor

xueqingz commented Nov 4, 2024

Java SDK build failed on:

    /**
     * If the bundle repository or remote_pool repository is enabled, it should be the only one enabled repository of the pool.
     */
    public static class RepoShouldBeSingleEnabled extends XenAPIException {
        public final String repo-type;

        /**
         * Create a new RepoShouldBeSingleEnabled
         */
        public RepoShouldBeSingleEnabled(String repo-type) {
            super("If the bundle repository or remote_pool repository is enabled, it should be the only one enabled repository of the pool.");
            this.repo-type = repo-type;
        }
    }

Consider change the name "repo-type" to "repo_type" ?

ocaml/idl/datamodel_errors.ml Outdated Show resolved Hide resolved
@BengangY
Copy link
Contributor Author

BengangY commented Nov 4, 2024

Java SDK build failed on:

    /**
     * If the bundle repository or remote_pool repository is enabled, it should be the only one enabled repository of the pool.
     */
    public static class RepoShouldBeSingleEnabled extends XenAPIException {
        public final String repo-type;

        /**
         * Create a new RepoShouldBeSingleEnabled
         */
        public RepoShouldBeSingleEnabled(String repo-type) {
            super("If the bundle repository or remote_pool repository is enabled, it should be the only one enabled repository of the pool.");
            this.repo-type = repo-type;
        }
    }

Consider change the name "repo-type" to "repo_type" ?

Updated to "repo_type" and it passed now.

@BengangY BengangY requested a review from lindig November 4, 2024 13:19
ocaml/xapi-consts/api_errors.ml Outdated Show resolved Hide resolved
@BengangY BengangY force-pushed the private/bengangy/CP-51988 branch 2 times, most recently from 98e7102 to a2a7936 Compare November 6, 2024 10:29
ocaml/xapi/xapi_pool.ml Outdated Show resolved Hide resolved
ocaml/idl/datamodel_errors.ml Outdated Show resolved Hide resolved
1. `remote_pool` repo doesn't support periodic sync updates.
2. Periodic sync updates should be auto-disabled when calling `set_repositories`
   and `add_repository` for `remote_pool` repo.
3. If `remote_pool` repository is enabled, it should be the single one
   enabled.

Signed-off-by: Bengang Yuan <[email protected]>
@BengangY BengangY merged commit deb25d2 into xapi-project:feature/easier-pool-join Nov 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants