CA-406770: Improve error message #6537
Merged
+22
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Jun 16, 2025
BengangY
force-pushed
the
private/bengangy/CA-406770
branch
2 times, most recently
from
3b4025c to
79f739b
Compare
psafont
reviewed
Jun 23, 2025
1. WLB request will raise `wlb_authentication_failed` when catching `Http_client.Http_error`. But actually only error code 401 and 403 should raise this type exception. For other error code, raise `wlb_connection_reset`. Also print the detail error code and message. 2. `message_forwarding` raises same error for `Http_request_rejected` and `Connection_reset` so we don't know which exception actually be raised. Print detailed logs for these 2 exceptions. Signed-off-by: Bengang Yuan <[email protected]>
BengangY
force-pushed
the
private/bengangy/CA-406770
branch
from
79f739b to
9d24689
Compare
psafont
approved these changes
Jun 23, 2025
lindig
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wlb_authentication_failedwhen catchingHttp_client.Http_error. But actually only error code 401 and 403 should raise this type exception. For other error code, raisewlb_connection_reset. Also print the detail error code and message.message_forwardingraises same error forHttp_request_rejectedandConnection_resetso we don't know which exception actually be raised. Print detailed logs for these 2 exceptions.