Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream packages #655

Merged
merged 58 commits into from
Sep 27, 2023
Merged

Update upstream packages #655

merged 58 commits into from
Sep 27, 2023

Conversation

psafont
Copy link
Member

@psafont psafont commented Aug 21, 2023

None of the changes should break the current toolstack as they are minor changes.

Breaking updates that were excluded from this PR:

  • mirage-crypto: RNG initialization needs now an explicit PRNG module
  • ocamlformat formats code in a different way

Follows #654

Draft to see changes inquality gates and fix them

Adds support for Linux's eventfd

Signed-off-by: Pau Ruiz Safont <[email protected]>
Maintenance release, uses new cmdliner interfaces

Signed-off-by: Pau Ruiz Safont <[email protected]>
Maintenance release, compatibility with newer ctypes releases

Signed-off-by: Pau Ruiz Safont <[email protected]>
Changes the output of the rdd updates, not it's legal JSON and has the
same format as other endpoints

Signed-off-by: Pau Ruiz Safont <[email protected]>
@psafont psafont force-pushed the update branch 4 times, most recently from 63c7123 to 5078bf4 Compare August 21, 2023 16:57
@psafont
Copy link
Member Author

psafont commented Aug 21, 2023

Current state of held-off packages and missing updates:

$ opam repo add default; and opam repo priority default 1; env OPAMNO=true opam upgrade -a ssl.0.6.0 base.v0.15.1 tar.2.3.0 ocurl.0.9.1 mirage-crypto.0.10.7 ocamlformat.0.22.4 | grep -E "↗|∗"
  ↗ ocamlformat-rpc-lib        0.22.4 to 0.26.0
Proceed with ↻ 88 recompilations and ↗ 1 upgrade? [y/n] n

@psafont psafont marked this pull request as ready for review August 21, 2023 16:59
@edwintorok
Copy link
Contributor

It is probably best to keep ocamlformat and ocamlformat-rpc-lib versions the same, what prevents that ocamlformat-rpc-lib upgrade from working?

@@ -0,0 +1,31 @@
opam-version: "2.0"
name: "polly"
version: "0.4.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were quite a few changes to the C bindings here, I think there might still be some outstanding PRs on the upstream repo that I didn't review, I'll try to take another look.

@psafont
Copy link
Member Author

psafont commented Aug 22, 2023

It is probably best to keep ocamlformat and ocamlformat-rpc-lib versions the same, what prevents that ocamlformat-rpc-lib upgrade from working?

I probably works, but I'd rather keep them at the same version, sometimes the version bounds in the dependent packages can be too lax. SInce it's not a critical revision of the library, I'd rather hold it off from upgrading

Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Pau Ruiz Safont <[email protected]>
For some reason is was in the wrong level, and it's needed to compile
goblint

Signed-off-by: Pau Ruiz Safont <[email protected]>
the dependency was not used. Unfortunately it cannot be removed from the
repository as it's used for testing ppx_cstruct

Signed-off-by: Pau Ruiz Safont <[email protected]>
0.7.0 is not usable because it requires openssl 1.1.0, which is not
available in xenserver at the time

Signed-off-by: Pau Ruiz Safont <[email protected]>
This version contains fixes to leaks on errors

Signed-off-by: Pau Ruiz Safont <[email protected]>
They contain maintenance fixes for updates optional libraries

Signed-off-by: Pau Ruiz Safont <[email protected]>
This is a breaking change because the build system was ported to dune.
Unix-errno has been updated accordingly

Signed-off-by: Pau Ruiz Safont <[email protected]>
Newer versions up to 2.5.1 exist, but they are known to be buggy

Signed-off-by: Pau Ruiz Safont <[email protected]>
Uses more efficient representation for ipv6 addresses and fixes some
bugs around them as well

Signed-off-by: Pau Ruiz Safont <[email protected]>
API surface expanded, no fixes of note

Signed-off-by: Pau Ruiz Safont <[email protected]>
api surface expanded, no fixes of note

Signed-off-by: Pau Ruiz Safont <[email protected]>
fix dates in output and make socket closing more robust

Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Pau Ruiz Safont <[email protected]>
Removes workaround for mirage 3

Signed-off-by: Pau Ruiz Safont <[email protected]>
Adds support for dune formatter

Signed-off-by: Pau Ruiz Safont <[email protected]>
maintenance release with a single fix

Signed-off-by: Pau Ruiz Safont <[email protected]>
Contains a fix on length counting

Signed-off-by: Pau Ruiz Safont <[email protected]>
Adds ocaml 5 support

Signed-off-by: Pau Ruiz Safont <[email protected]>
Added ability to differentiate between signed and unsigned args

Signed-off-by: Pau Ruiz Safont <[email protected]>
removed dependency to io-page, raises excepcion on non-aligned files on
sector-size

Signed-off-by: Pau Ruiz Safont <[email protected]>
Remove io-page dependency

Signed-off-by: Pau Ruiz Safont <[email protected]>
Removes several deprecated functions and types, doesn't seem to affect
our code

Signed-off-by: Pau Ruiz Safont <[email protected]>
@psafont psafont force-pushed the update branch 2 times, most recently from a04c32c to cefe675 Compare September 25, 2023 15:09
They seem happy when updated together, so go for it

Signed-off-by: Pau Ruiz Safont <[email protected]>
Adds a few missing features to some of the backends

Signed-off-by: Pau Ruiz Safont <[email protected]>
Added the compare function

Signed-off-by: Pau Ruiz Safont <[email protected]>
Maintenance release, ported to dune and ocaml 5.1 compatibility

Signed-off-by: Pau Ruiz Safont <[email protected]>
There are some tweaks in the conf packages, some tweaks in the
dependency versions and change the uri packages location to reflect they
are patched

Signed-off-by: Pau Ruiz Safont <[email protected]>
@psafont
Copy link
Member Author

psafont commented Sep 26, 2023

Passed a toolstack BVT + BST test, this needs another review

@psafont psafont merged commit f38d195 into xapi-project:master Sep 27, 2023
2 checks passed
@psafont psafont deleted the update branch September 27, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants