Add patch for XSI-1457 to ocaml-vhd #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vincent-lau
approved these changes
Feb 28, 2024
| + s >>= fun next -> | ||
| + match (next, acc) with | ||
| | End, None -> return End | ||
| - | End, Some x -> return (Cons(x, fun () -> return End)) |
There was a problem hiding this comment.
why is it deleting this line and then add the same one back in line 67?
There was a problem hiding this comment.
I would not focus on the shape of the diff and more on the result. I had to do this manually and first re-formatted the existing code and then changed it. So it's important not to miss something.
robhoes
approved these changes
Feb 29, 2024
|
I could have sworn I had added a comment already. Please change the version to 0.12.0+1 to make it obvious there's a patch applied when looking at the version |
Signed-off-by: Christian Lindig <[email protected]>
lindig
force-pushed
the
release/yangtze/lcm
branch
from
ac5bb81 to
678aa69
Compare
|
I've bumped the version to 0.12.1 @psafont |
psafont
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are patching an upstream project by adding a patch to the opam file. The original is here:
xapi-project/xen-api@db4d465