Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated firmware/commit to return a firmware object. #113

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Updated firmware/commit to return a firmware object. #113

merged 1 commit into from
Apr 14, 2020

Conversation

glfejer
Copy link
Contributor

@glfejer glfejer commented Apr 13, 2020

Fixes issue #112

@glfejer glfejer requested review from drbild and iguberman April 13, 2020 23:14
@glfejer glfejer self-assigned this Apr 13, 2020
drbild
drbild approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@drbild drbild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The CI failed while trying to install the dependencies. I just restarted the failed jobs to see if those were transient failures or actual problem due to changes in the upstream debian repos.

@drbild
Copy link
Contributor

drbild commented Apr 14, 2020

The CI failed while trying to install the dependencies. I just restarted the failed jobs to see if those were transient failures or actual problem due to changes in the upstream debian repos.

Ugh, cmake in stretch-backports was updated to require a version of libarchive13 that is not yet in sretch-backports. Hopefully that gets corrected quickly.

@drbild drbild self-requested a review April 14, 2020 21:14
drbild
drbild approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@drbild drbild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@glfejer
Updated firmware/commit to return a firmware object.
cc74595 
Removed broken stretch-backport version of cmake.
@glfejer glfejer merged commit 4cdefca into master Apr 14, 2020
@glfejer glfejer deleted the fw_commit_update branch April 14, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbild drbild drbild approved these changes

@iguberman iguberman Awaiting requested review from iguberman

Assignees

@glfejer glfejer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glfejer @drbild