Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy signed artifacts to S3. #180

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Deploy signed artifacts to S3. #180

merged 1 commit into from
Nov 11, 2020

Conversation

glfejer
Copy link
Contributor

@glfejer glfejer commented Nov 10, 2020 •
edited
Loading

Fixes #173

@glfejer glfejer marked this pull request as ready for review November 11, 2020 17:48
@glfejer glfejer requested a review from drbild November 11, 2020 17:48
drbild
drbild approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@drbild drbild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@drbild
Copy link
Contributor

drbild commented Nov 11, 2020

Could you also mark this as fixing #173?

@glfejer glfejer merged commit fc4748c into master Nov 11, 2020
@glfejer glfejer deleted the fej/deploy-to-aws branch November 11, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drbild drbild drbild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: fix deployment of dev artifacts
2 participants
@glfejer @drbild