Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify place to add new column types #1060

Merged
merged 7 commits into from
Jul 4, 2023
Merged

Unify place to add new column types #1060

merged 7 commits into from
Jul 4, 2023

Conversation

SferaDev
Copy link
Member

@SferaDev SferaDev commented Jul 4, 2023

Right now we need to add new column types in multiple places, add a common way to add them and import

@SferaDev SferaDev requested a review from a team as a code owner July 4, 2023 07:16
@changeset-bot
Copy link

changeset-bot bot commented Jul 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: bbe65cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SferaDev
Add dep
9913a1f 
Signed-off-by: Alexis Rico <[email protected]>
@SferaDev
Update to pnpm v8
28b9c26 
Signed-off-by: Alexis Rico <[email protected]>
@SferaDev SferaDev changed the base branch from main to pnpm_v8 July 4, 2023 07:39
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023 •
edited
Loading

size-limit report 📦

Path Size
packages/client/dist/index.mjs 15.8 KB (+0.38% 🔺)
packages/client/dist/index.cjs 17 KB (+0.41% 🔺)
packages/codegen/dist/index.mjs 2.55 MB (+0.49% 🔺)
packages/codegen/dist/index.cjs 2.56 MB (+0.66% 🔺)

richardgill
richardgill approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@richardgill richardgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left a non-blocking question

packages/codegen/package.json
@@ -31,6 +31,7 @@
},
"homepage": "https://github.com/xataio/client-ts/blob/main/codegen/README.md",
"dependencies": {
"@xata.io/client": "workspace:*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come this changed?

Copy link
Member Author

@SferaDev SferaDev Jul 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't use anything from the client before and we are now using something so in order to be able to import it we need to add it as a dependency.

Base automatically changed from pnpm_v8 to main July 4, 2023 10:57
@SferaDev SferaDev enabled auto-merge July 4, 2023 10:58
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Your pull request has been published to npm.

You can install it by running:

npm install @xata.io/[email protected]

To test the CLI, run:

npx @xata.io/[email protected]

@SferaDev SferaDev added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit 09f6d00 Jul 4, 2023
6 checks passed
@SferaDev SferaDev deleted the column-types branch July 4, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardgill richardgill richardgill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SferaDev @richardgill