Ensure that inline CHECK constraints are named

When converting inline `CHECK` constraints in `CREATE TABLE` statements,
ensure that the constraint is named according to Postgres naming
conventions for inline `CHECK` constraints.

pkg/sql2pgroll/create_table.go

@@ -26,7 +26,7 @@ func convertCreateStmt(stmt *pgq.CreateStmt) (migrations.Operations, error) {
 	for _, elt := range stmt.TableElts {
 		switch elt.Node.(type) {
 		case *pgq.Node_ColumnDef:
-			column, err := convertColumnDef(elt.GetColumnDef())
+			column, err := convertColumnDef(stmt.Relation.GetRelname(), elt.GetColumnDef())
 			if err != nil {
 				return nil, fmt.Errorf("error converting column definition: %w", err)
 			}
@@ -41,7 +41,7 @@ func convertCreateStmt(stmt *pgq.CreateStmt) (migrations.Operations, error) {
 
 	return migrations.Operations{
 		&migrations.OpCreateTable{
-			Name:    stmt.Relation.Relname,
+			Name:    stmt.Relation.GetRelname(),
 			Columns: columns,
 		},
 	}, nil
@@ -76,7 +76,7 @@ func canConvertCreateStatement(stmt *pgq.CreateStmt) bool {
 	}
 }
 
-func convertColumnDef(col *pgq.ColumnDef) (*migrations.Column, error) {
+func convertColumnDef(tableName string, col *pgq.ColumnDef) (*migrations.Column, error) {
 	if !canConvertColumnDef(col) {
 		return nil, nil
 	}
@@ -116,7 +116,7 @@ func convertColumnDef(col *pgq.ColumnDef) (*migrations.Column, error) {
 			pk = true
 			notNull = true
 		case pgq.ConstrType_CONSTR_CHECK:
-			check, err = convertInlineCheckConstraint(c.GetConstraint())
+			check, err = convertInlineCheckConstraint(tableName, col.GetColname(), c.GetConstraint())
 			if err != nil {
 				return nil, fmt.Errorf("error converting inline check constraint: %w", err)
 			}
@@ -171,7 +171,7 @@ func canConvertPrimaryKeyConstraint(constraint *pgq.Constraint) bool {
 	}
 }
 
-func convertInlineCheckConstraint(constraint *pgq.Constraint) (*migrations.CheckConstraint, error) {
+func convertInlineCheckConstraint(tableName, columnName string, constraint *pgq.Constraint) (*migrations.CheckConstraint, error) {
 	if !canConvertCheckConstraint(constraint) {
 		return nil, nil
 	}
@@ -181,7 +181,13 @@ func convertInlineCheckConstraint(constraint *pgq.Constraint) (*migrations.Check
 		return nil, fmt.Errorf("failed to deparse CHECK expression: %w", err)
 	}
 
+	name := fmt.Sprintf("%s_%s_check", tableName, columnName)
+	if constraint.GetConname() != "" {
+		name = constraint.GetConname()
+	}
+
 	return &migrations.CheckConstraint{
+		Name:       name,
 		Constraint: expr,
 	}, nil
 }

pkg/sql2pgroll/expect/create_table.go

@@ -111,6 +111,7 @@ var CreateTableOp10 = &migrations.OpCreateTable{
 			Type:     "int",
 			Nullable: true,
 			Check: &migrations.CheckConstraint{
+				Name:       "foo_a_check",
 				Constraint: "a > 0",
 			},
 		},