Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert DROP INDEX SQL to pgroll operation #524

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Convert DROP INDEX SQL to pgroll operation #524

merged 6 commits into from
Dec 11, 2024

Conversation

ryanslade
Copy link
Collaborator

@ryanslade ryanslade commented Dec 11, 2024 •
edited
Loading

Converts SQL in the following forms to the equivalent pgroll operation:

DROP INDEX foo
DROP INDEX schema.foo
DROP INDEX foo RESTRICT
DROP INDEX CONCURRENTLY foo
DROP INDEX IF EXISTS foo

The following forms are left as raw SQL operations since we do not support them in pgroll yet:

DROP INDEX foo CASCADE

Part of #504

ryanslade
ryanslade commented Dec 11, 2024
View reviewed changes
pkg/sql2pgroll/drop.go Outdated Show resolved Hide resolved
@ryanslade ryanslade mentioned this pull request Dec 11, 2024
Open
andrew-farries
andrew-farries reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 , left some comments

pkg/sql2pgroll/drop.go Outdated Show resolved Hide resolved
pkg/sql2pgroll/drop.go Outdated Show resolved Hide resolved
pkg/sql2pgroll/drop_test.go Outdated Show resolved Hide resolved
pkg/sql2pgroll/drop.go Outdated Show resolved Hide resolved
@ryanslade
Copy link
Collaborator Author

@andrew-farries PTAL

@ryanslade ryanslade merged commit ac222a4 into main Dec 11, 2024
27 checks passed
@ryanslade ryanslade deleted the rs/sql2pgroll-drop-index branch December 11, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanslade @andrew-farries