Build CGO_ENABLED binaries for supported platforms in the release job
#527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-farries
force-pushed
the
cross-build-in-release-job
branch
4 times, most recently
from
37df9c7 to
097d705
Compare
andrew-farries
force-pushed
the
cross-build-in-release-job
branch
from
097d705 to
7f8da80
Compare
ryanslade
reviewed
Dec 12, 2024
ryanslade
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
releasejob run in agoreleaser/goreleaser-crosscontainer so that we can build binaries for all supported architectures.See the PR description for #525 for details of why we need a cross-compilation toolchain as a result of taking a dependency on
pg_query_goand how the thegoreleaser-crossimage is used.The addition of the
-staticLDFLAGfor thelinux/amd64andlinux/arm64builds is necessary to statically link in order for the resultingpgrollbinaries to run in theFROM scratchimage thatGoreleaseruses to build docker images.Also, revert #515 to re-add the
pgroll sqlcommand now thatpgrollcan be built for all platforms when the dependency onpg_query_gois included in the build.