Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xataio fork of pg_query_go package #534

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

andrew-farries
Copy link
Collaborator

Switch the pg_query_go dependency from https://github.com/pganalyze/pg_query_go to the fork at https://github.com/xataio/pg_query_go

The forked version adds a new DeparseExpr function for deparsing expression nodes (see xataio/pg_query_go#1). This will expand the range of SQL DDL statements that sql2pgroll is able to convert to pgroll migrations.

Part of #504

@andrew-farries andrew-farries marked this pull request as ready for review December 16, 2024 09:05
@andrew-farries andrew-farries merged commit de49197 into main Dec 16, 2024
28 checks passed
@andrew-farries andrew-farries deleted the use-xataio-fork-pg-query-go branch December 16, 2024 09:09
github.com/pterm/pterm v0.12.80
github.com/santhosh-tekuri/jsonschema/v5 v5.3.1
github.com/spf13/cobra v1.8.1
github.com/spf13/viper v1.19.0
github.com/stretchr/testify v1.10.0
github.com/testcontainers/testcontainers-go v0.34.0
github.com/testcontainers/testcontainers-go/modules/postgres v0.34.0
github.com/xataio/pg_query_go/v6 v6.0.0-20241216080535-894186571799
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw you could also use https://go.dev/doc/modules/gomod-ref#replace, this came handy in the past to avoid import chaos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants