Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unconvertible CREATE TABLE statements #546

Merged
merged 9 commits into from
Dec 18, 2024
Merged

Handle unconvertible CREATE TABLE statements #546

merged 9 commits into from
Dec 18, 2024

Conversation

andrew-farries
Copy link
Collaborator

@andrew-farries andrew-farries commented Dec 18, 2024 •
edited
Loading

There are many options for the CREATE TABLE statement in Postgres, most of which are not currently representable by the pgroll OpCreateTable operation.

Add tests to ensure that sql2proll.Convertfalls back to raw SQL operations when these unconvertible options are present in a SQL statement.

Part of #504

@andrew-farries
Fall back to raw SQL for TEMPORARY tables
3d29aa8 
Temporary tables are not representable as `pgroll` `OpCreateTable`
operations.
@andrew-farries
Fall back to raw SQL for UNLOGGED tables
839e4a5 
Unlogged tables are not representable as `pgroll` `OpCreateTable`
operations.
@andrew-farries
Fall back to raw SQL for IF NOT EXISTS
2ec9e49 
`CREATE TABLE IF NOT EXISTS` is not representable as a `pgroll`
operation.
@andrew-farries
Fall back to raw SQL for INHERITS clause
ae02568 
`CREATE TABLE ... INHERITS` is not representable as a `pgroll`
operation.
@andrew-farries
Fall back to raw SQL for PARTITION clause
ac92492 
Paritioned tables are not representable as an `OpCreateTable` operation.
@andrew-farries
Fall back to raw SQL for USING clause
4ddd354 
Different table access methods are not representable as an
`OpCreateTable` operation.
@andrew-farries
Fall back to raw SQL for WITH clause
2ba3621 
Storage options are not representable as an `OpCreateTable` operation.
@andrew-farries
Fall back to raw SQL for ON COMMIT clause
a0fceb5 
On commit options are not representable as an `OpCreateTable` operation.
@andrew-farries
Fall back to raw SQL for TABLESPACE clause
bcb4802 
Tablespace options are not representable as an `OpCreateTable`
operation.
@andrew-farries andrew-farries added the sql2pgroll Issues relating to the sql2pgroll package label Dec 18, 2024
@andrew-farries andrew-farries marked this pull request as ready for review December 18, 2024 08:27
@andrew-farries andrew-farries merged commit a849534 into main Dec 18, 2024
28 checks passed
@andrew-farries andrew-farries deleted the unconvertable-create-table-statements branch December 18, 2024 09:03
This was referenced Dec 18, 2024
Merged
Open
andrew-farries added a commit that referenced this pull request Dec 18, 2024
@andrew-farries
Handle more unconvertible CREATE TABLE statements (#547)
b727101 
Build on #546 and ensure that more `CREATE TABLE` statements with
options and clauses that are not representable as `pgroll`
`OpCreateTable` operations fall back to raw SQL.

Part of #504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

@ryanslade ryanslade Awaiting requested review from ryanslade

Assignees
No one assigned
Labels
sql2pgroll Issues relating to the sql2pgroll package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-farries @exekias