Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to raw SQL for GENERATED columns in CREATE TABLE statements #555

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

andrew-farries
Copy link
Collaborator

Ensure that CREATE TABLE statements with generated columns are converted to raw SQL operations; they can't currently be represented as Columns in an OpCreateTable

@andrew-farries andrew-farries marked this pull request as ready for review December 19, 2024 12:15
@andrew-farries andrew-farries force-pushed the convert-create-table-inline-fk branch from ca17cca to ae898a3 Compare December 19, 2024 12:57
@andrew-farries andrew-farries force-pushed the fall-back-to-sql-for-generated-columns branch from fa641ad to 01eb345 Compare December 19, 2024 12:57
@andrew-farries andrew-farries force-pushed the convert-create-table-inline-fk branch from ae898a3 to 68ef5c4 Compare December 19, 2024 13:12
@andrew-farries andrew-farries force-pushed the fall-back-to-sql-for-generated-columns branch from 01eb345 to ef7cf14 Compare December 19, 2024 13:12
@andrew-farries andrew-farries force-pushed the convert-create-table-inline-fk branch from 68ef5c4 to e15a153 Compare December 19, 2024 13:17
@andrew-farries andrew-farries force-pushed the fall-back-to-sql-for-generated-columns branch from ef7cf14 to ae7ba5f Compare December 19, 2024 13:17
@andrew-farries andrew-farries force-pushed the convert-create-table-inline-fk branch from e15a153 to f02565f Compare December 19, 2024 13:20
@andrew-farries andrew-farries force-pushed the fall-back-to-sql-for-generated-columns branch from ae7ba5f to 05706a1 Compare December 19, 2024 13:20
Base automatically changed from convert-create-table-inline-fk to main December 19, 2024 13:28
Ensure that `CREATE TABLE` statements with generated columns are converted
to raw SQL.
@andrew-farries andrew-farries force-pushed the fall-back-to-sql-for-generated-columns branch from 05706a1 to 6be317b Compare December 19, 2024 13:29
@andrew-farries andrew-farries merged commit 627b64e into main Dec 19, 2024
28 checks passed
@andrew-farries andrew-farries deleted the fall-back-to-sql-for-generated-columns branch December 19, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants