Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLSTree] Fix missing codec for media playlist #1328

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[HLSTree] Fix missing codec for media playlist #1328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/parser/HLSTree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,14 +951,18 @@ bool adaptive::CHLSTree::ParseManifest(const std::string& data)
}
else if (tagName == "#EXTINF")
{
// This is not a multi - bitrate playlist
// This is a media playlist (not a master playlist with multi-bitrate playlist)

//! @todo: here we are add some fake data, and we are downloading two times the same manifest
//! because the current parser code is splitted on two parts and managed from different code,
//! to solve this situation a rework is needed, where we can have a seletable parsing method
auto newAdpSet = CAdaptationSet::MakeUniquePtr(period.get());
newAdpSet->SetStreamType(StreamType::VIDEO);

auto repr = CRepresentation::MakeUniquePtr(newAdpSet.get());
repr->SetTimescale(1000000);
repr->SetSourceUrl(manifest_url_);
repr->AddCodecs(CODEC::FOURCC_H264);

repr->assured_buffer_duration_ = m_settings.m_bufferAssuredDuration;
repr->max_buffer_duration_ = m_settings.m_bufferMaxDuration;
Expand Down
Loading