-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement set audio profile from demuxer #1356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CastagnaIT
force-pushed
the
audioProfiles
branch
2 times, most recently
from
August 17, 2023 09:03
1cad635
to
88682a8
Compare
CastagnaIT
added
Type: Improvement
non-breaking change which improves existing functionality
v21 Omega
labels
Aug 17, 2023
CastagnaIT
force-pushed
the
audioProfiles
branch
from
August 21, 2023 13:31
8d39a85
to
3bfe38f
Compare
@glennguy in awaiting that xbmc PR's are merged, you can prepare review |
glennguy
approved these changes
Aug 22, 2023
Looks good! |
If codec name its the same dont override the internal codec name to prevent to get lost the custom ec3-joc internal name this is needed until kodi implements ffmpeg 6.1 or greater from that version can detect the Atmos profile
CastagnaIT
force-pushed
the
audioProfiles
branch
from
August 24, 2023 12:52
3bfe38f
to
e6c3f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea is use the "full codec string" (RFC 6381) to set the codec profile as hint from manifest data,
so that not influence decoders, then when start play the stream we set the right profile provided by demuxers.
fix #650
references used to implement Atmos signal as codec DD+ profile:
https://developer.apple.com/documentation/http-live-streaming/hls-authoring-specification-for-apple-devices-appendixes
https://ott.dolby.com/OnDelKits/DDP/Dolby_Digital_Plus_Online_Delivery_Kit_v1.5/Documentation/Content_Creation/SDM/help_files/topics/ddp_mpeg_dash_c_signal_atmos_in_isobmf_2.html
Smooth streaming manifest case
this manifest works differents and its more complex find a good solution due to handmade Movie Atoms,
so its use
CSession::CreateMovieAtom
to allowCFragmentedSampleReader
to determinate codec type,but currently create an appropriate audio SampleDescription require some code reworks and will not be considered here.
This means that for now smooth streaming cases there are no codec profiles.
This PR depends from xbmc PR's:
xbmc/xbmc#23524
xbmc/xbmc#23541
BEFORE
AFTER
Motivation and context
Set the missing audio profile and allow distinguish from kodi GUI audio track list the type of codec since multiple tracks could have same characteristics with same language, but different codec quality
How has this been tested?
For HLS, following sample include most common audio codec types included atmos:
https://devstreaming-cdn.apple.com/videos/streaming/examples/adv_dv_atmos/main.m3u8
Smooth streaming, no changes, read note in description
DASH Atmos: https://ott.dolby.com/OnDelKits/DDP/Dolby_Digital_Plus_Online_Delivery_Kit_v1.4.1/Test_Signals/muxed_streams/DASH/OnDemand_MPD/ChID_voices_1280x720p_25fps_h264_6ch_640kbps_ddp_joc.mpd
Screenshots (if appropriate):
Types of change
Checklist: