[HLSTree] Fixes for parser regressions #1364
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current RemoveParameters method can be misleading and can delete required url parts
so cleaned up method by removing "filename" variable,
and then created an appropriate method to get url path
HLS D+ manifest case has shown another time some things that has not been taken in account after recent parser rework
First thing, multiple variants with same uri, was added more times as representation
Second thing, on renditions there may exists multile renditions with same identical properties but different GROUP-ID
and we should not add them more times
The last one when we parse a child manifest that have multiple EXT-X-DISCONTINUITY was missing add base url to representations of switched period, and was causing bad download url address
Motivation and context
fix #1335 #1366
How has this been tested?
i wait user feedback as confirm
i tested some random dash/hls/ss
Screenshots (if appropriate):
Types of change
Checklist: