-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRM][ClearKey] Add license url by DRM config, CK as DRM replacement #1638
Conversation
ec3af78
to
5753163
Compare
What about extracting the default_KID from the urn:uuid:edef8ba9-79d6-4ace-a3c8-27dcd51d21ed PSSH if the default_KID doesn't exist? |
iirc dash specs say an improvement would be when not found extract it from the mp4box, but this is a change that i want left after the DRM config rework to do what you propose currently its needed add a workaround that in theory can be avoided after the rework |
df38035
to
84497b4
Compare
This should allow play Widevine streams by using ClearKey DRM untested since i havent found a sample
Mainly: - Avoid use of mixed DRM properties - Make working new "drm" property, in a temporary limited way for test
e91b59a
to
82739a9
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
@moszkowski97 your problems are because you are using wrong ISA properties and wrong url pipe "|" along the URL is not supported on ISA and not specified on Wiki, i suggest you for full read the Wiki integration page and recheck what you are doing, |
@alannl thanks i have saved it, your comment deleted as requested, to avoid keep comment history |
@CastagnaIT FYI, via actibity API all "deleted" comments (even from "deleted" accounts!) are visible just fine :) |
@CastagnaIT |
no, dont use development PR's for discussions |
Description
Add support to set license server url from property, example:
#KODIPROP:inputstream.adaptive.drm_legacy=org.w3.clearkey|https://server/AcquireLicense
Add support to pass http headers to license server request
Tested DASH Widevine stream, used with ClearKey as DRM replacement, as requested on Support for clearkey #811 and [Feature request] Add support for fetching keys from Licence Server #1637.
The only limitation is that the manifest must provide the ContentProtection withurn:mpeg:dash:mp4protection:2011
containing thedefault_KID
Add support "ClearKey as DRM replacement" for HLS, but not tested since i havent found any stream
Add code to prevent a mixed misuse of DRM properties
Some code cleanups
Motivation and context
closes #1637
closes #811
How has this been tested?
Tested MPD widevine protected by using ClearKey license server url provided by DRM config property, the tested MPD does not provide the ClearKey
ContentProtection
tag, as follow:i cant publish here the test stream used
Screenshots (if appropriate):
Types of change
Checklist: