[Depends][Bento4] Cleanups to remove some patches #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most rilevant change, add our implementation of ReadGolomb in order to remove bento4 custom patch
Added to remove bento4 custom patch
This allow to remove custom bento4 changes
CastagnaIT
added
Type: Cleanup
CastagnaIT
force-pushed
the
bento_patches
branch
from
bc1030f
to
612a45d
Compare
CastagnaIT
added
the
On hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanups to remove some patches
i try waiting an answer of the maintainer on axiomatic-systems/Bento4#977
to understand what changes to be included or not on our bento4 repo
Motivation and context
A bit less commits to maintains on our custom bento4
How has this been tested?
Already tested on android also to check DolbyDigital+ bento4 regression (recently fixed)
Screenshots (if appropriate):
Types of change
Checklist: