Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced std::atomic<struct> with mutex #1701

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Replaced std::atomic<struct> with mutex #1701

merged 2 commits into from
Oct 16, 2024

Conversation

CastagnaIT
Copy link
Collaborator

Description

This remove #1683 fixes and also atomic code introduced by #1680
looks like its not a good pratice use atomic structs
as on discussion LibreELEC/LibreELEC.tv#9395

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT
Replaced std::atomic<struct> with mutex
f0f0fae 
this is the cause of building errors on some linux compilers:
undefined symbol: __atomic_store_16

looks like its not a good pratice use atomic with structs
@CastagnaIT
[cmakelists] removed atomic library linking
c50549a
@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue Component: Build v22 Piers labels Oct 16, 2024
@CastagnaIT CastagnaIT mentioned this pull request Oct 16, 2024
Open
@heitbaum
Copy link
Contributor

Tested with no references to __atomic_store_16 or __atomic_load_16

docker@3deacf278297:/var/media/DATA/home-rudi/LibreELEC.tv$ s/build inputstream.adaptive
UNPACK      inputstream.adaptive
    APPLY PATCH (common)      packages/mediacenter/kodi-binary-addons/inputstream.adaptive/patches/1701.patch

...

$ objdump -T build.LibreELEC-Generic.x86_64-13.0-devel/install_pkg/inputstream.adaptive-22.1.6-Piers/usr/lib/kodi/addons/inputstream.adaptive/inputstream.adaptive.so.22.1.6|grep __atomic
0000000000000000      DF *UND*  0000000000000000 (GLIBCXX_3.4.21) _ZNSt28__atomic_futex_unsigned_base19_M_futex_wait_untilEPjjbNSt6chrono8durationIlSt5ratioILl1ELl1EEEENS2_IlS3_ILl1ELl1000000000EEEE
0000000000000000      DF *UND*  0000000000000000 (GLIBCXX_3.4.21) _ZNSt28__atomic_futex_unsigned_base19_M_futex_notify_allEPj

@CastagnaIT CastagnaIT merged commit 4ff9952 into xbmc:Piers Oct 16, 2024
10 checks passed
@CastagnaIT CastagnaIT deleted the replace_atomic branch October 16, 2024 08:54
@heitbaum heitbaum mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Build Type: Fix non-breaking change which fixes an issue v22 Piers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CastagnaIT @heitbaum