Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation with the not yet released GCC 15 #1753

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix compilation with the not yet released GCC 15 #1753

merged 2 commits into from
Jan 9, 2025

Conversation

neo1973
Copy link
Member

@neo1973 neo1973 commented Jan 6, 2025

Description

Fix compilation with the not yet released GCC 15. Discussion and explanation of the change can be seen in #1739, specifically #1739 (comment).

Motivation and context

Fixes #1739.

How has this been tested?

It compiles 😄

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@neo1973 neo1973 added Type: Fix non-breaking change which fixes an issue v22 Piers labels Jan 6, 2025
CastagnaIT
CastagnaIT reviewed Jan 6, 2025
View reviewed changes
src/parser/DASHTree.cpp Outdated Show resolved Hide resolved
CastagnaIT
CastagnaIT approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@CastagnaIT CastagnaIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested & debugged on windows lgtm thanks

@CastagnaIT CastagnaIT merged commit 840cd55 into xbmc:Piers Jan 9, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CastagnaIT CastagnaIT CastagnaIT approved these changes

Assignees
No one assigned
Labels
Type: Fix non-breaking change which fixes an issue v22 Piers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Compile error with gcc-15
2 participants
@neo1973 @CastagnaIT