-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[script.video.nfl.gamepass] 2022.11.14 #2334
Conversation
@jm-duke As you did the previous PR's: Are you aware of this PR? And do you approve? |
@basrieter Of course I approve, I opened this PR :) If you meant to reach out to @aqw: He passed development on to me and already approved in the previous PR (#2306) |
I was confused about the source of the PR. Should have looked a bit further. |
+ Fix display of 'None' for focused games in game week view (jm-duke) | ||
+ Implemented some improvements highlighted by Bas Rieter (jm-duke) | ||
+ Minor refactorings (jm-duke) | ||
<news>2022.11.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this list correct? Seems like not all the changes are in the PR? If this was intentional, then NP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jm-duke did you see this last comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, kinda missed it ;-)
I haven't updated the news list on purpose, because this PR just added a minor feature and introduced a quick fix for an API change.
NFL has canceled Gamepass, so this add-on will cease to work in a few weeks. |
Ok. Could you submit a PR that marks it as broken? |
I submitted PR #2477, to remove it from the repo. Is that ok? |
Description
Addon
Name: NFL Game Pass
ID: script.video.nfl.gamepass
Version: 2022.11.14
Source: https://github.com/pigskin/kodi-gamepass
Info
NFL Game Pass is a service that allows those with subscriptions to watch NFL games. This add-on allows watching of live and past games via NFL's Game Pass service.
Updates
Adds a busy dialog when retrieving NFL Network content and fixes an issue introduced by a recent API change.
Checklist: