Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service.subtitles.ktuvit] 4.0.0 #2442

Merged
merged 3 commits into from
Jul 7, 2024
Merged

[service.subtitles.ktuvit] 4.0.0 #2442

merged 3 commits into from
Jul 7, 2024

Conversation

CaTzil
Copy link

@CaTzil CaTzil commented Apr 23, 2023

Description

Ktuvit subtitle plugin suitable for Nexus version

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Copy link
Collaborator

@romanvm romanvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix addon.xml, other changes are not mandatory.

service.subtitles.ktuvit/addon.xml Outdated Show resolved Hide resolved
service.subtitles.ktuvit/resources/lib/SUBUtilities.py Outdated Show resolved Hide resolved
service.subtitles.ktuvit/service.py Outdated Show resolved Hide resolved
@CaTzil
Copy link
Author

CaTzil commented Oct 31, 2023

I've made the addon changes, can you review it?

@romanvm
Copy link
Collaborator

romanvm commented Jan 1, 2024

Please fix the license identifier and the addon will be ready to be merged. Other comments are not mandatory.

@CaTzil
Copy link
Author

CaTzil commented Jan 2, 2024

@romanvm, I've updated my PR, please review it 🙏🏽

@CaTzil
Copy link
Author

CaTzil commented Apr 8, 2024

Ping?

@CaTzil CaTzil requested a review from romanvm May 6, 2024 17:52
@romanvm romanvm added Approved Approved and is ready to merge and removed waiting for developer to respond labels Jul 7, 2024
@romanvm romanvm merged commit 46d7490 into xbmc:nexus Jul 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants