Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script.wikipedia 0.0.4 #2466

Merged
merged 1 commit into from
Jul 14, 2023
Merged

script.wikipedia 0.0.4 #2466

merged 1 commit into from
Jul 14, 2023

Conversation

jurialmunkey
Copy link

Description

Simple scripted dialog XML for browsing wikipedia
NOTE: Requires #2465 to be merged as dependency.

RunScript(script.wikipedia,wikipedia=SEARCHQUERY)

See README.md for more advanced usage.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@jurialmunkey
Copy link
Author

Note check is failing because script.module.jurialmunkey dependency needs to be merged first.

Copy link
Collaborator

@romanvm romanvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanvm
Copy link
Collaborator

romanvm commented Jul 14, 2023

Looks like I cannot re-run the failed action that is too old. @jurialmunkey Could you push some trivial change to the PR like an extra space or a newline to trigger a new addon check?

@romanvm romanvm added Approved Approved and is ready to merge and removed waiting for dependency to be merged labels Jul 14, 2023
@romanvm romanvm merged commit 59bcd06 into xbmc:nexus Jul 14, 2023
1 check passed
@jurialmunkey jurialmunkey deleted the nexus_pr_wikipedia branch June 8, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants