Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.module.urllib3@matrix] 2.1.0 #2541

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

L2501
Copy link

@L2501 L2501 commented Nov 26, 2023

Description

update urllib3 to v2.1.0
https://github.com/urllib3/urllib3/releases/tag/2.1.0

urllib3 v2 migration: https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html
Possible issues in Kodi addons:
Requires OpenSSL 1.1.1 - included in Kodi 19.2+
default minimum TLS version set to 1.2
default TLS ciphers set by cPython instead of urllib3 some addons might need to set their ciphers urllib3/urllib3#3100
script.module.requests-cache might need update but it has many new dependencies.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@L2501
Copy link
Author

L2501 commented Nov 26, 2023

on another test it does break old requests-cache. NHK world TV addon (not in kodi repo) is one i know that use it.

@romanvm romanvm added the Approved Approved and is ready to merge label Dec 2, 2023
@romanvm romanvm merged commit e1a58c7 into xbmc:matrix Dec 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants