Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.cu.lrclyrics] 6.6.2 #2551

Merged
merged 1 commit into from
Dec 2, 2023
Merged

[script.cu.lrclyrics] 6.6.2 #2551

merged 1 commit into from
Dec 2, 2023

Conversation

ronie
Copy link
Member

@ronie ronie commented Nov 29, 2023

Description

  • removed dead scrapers
  • fixed broken scrapers
  • added new scrapers

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider to move scraper test to a test folder and avoid the inclusion in the distribution package. Apart from that, all good. Thanks for the update

@ronie
Copy link
Member Author

ronie commented Nov 29, 2023

the scraper test functionality is accessible from the addon settings and (to my surprise) some users are actually using it :-)

@romanvm romanvm added the Approved Approved and is ready to merge label Dec 2, 2023
@romanvm romanvm merged commit f0be59b into matrix Dec 2, 2023
1 check passed
@enen92 enen92 deleted the script.cu.lrclyrics-6.6.2 branch July 7, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants