Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service.subtitles.opensubtitles-com] 1.0.3 #2563

Merged
merged 5 commits into from
Jan 1, 2024

Conversation

opensubtitlesdev
Copy link

Description

Small fix on file path submitted by plex community opensubtitlesdev/service.subtitles.opensubtitles-com#15

Checklist:

* [x ] My code follows the [add-on rules](http://kodi.wiki/view/Add-on_rules) and [piracy stance](http://kodi.wiki/view/Official:Forum_rules#Piracy_Policy) of this project.

* [ x] I have read the [CONTRIBUTING](https://github.com/xbmc/repo-scripts/blob/master/CONTRIBUTING.md) document

* [ x] Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

* Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.

* [add-on development](http://kodi.wiki/view/Add-on_development) wiki page.

* Kodi [pydocs](http://kodi.wiki/view/PyDocs) provide information about the Python API

* [PEP8](https://www.python.org/dev/peps/pep-0008/) codingstyle which is considered best practise but not mandatory.

* This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at [Codacy](https://www.codacy.com/app/Kodi/repo-scripts/dashboard). You can create your own account as well to continuously monitor your python coding before submitting to repo.

* Development questions can be asked in the [add-on development](http://forum.kodi.tv/forumdisplay.php?fid=26) section on the Kodi forum.

@romanvm
Copy link
Collaborator

romanvm commented Dec 22, 2023

Please resolve merge conflicts.

@romanvm romanvm added the Don't Merge Do not merge this PR label Dec 22, 2023
@pannal
Copy link

pannal commented Jan 1, 2024

Happy new year!

This should be mergable, shouldn't it?

@romanvm romanvm removed the Don't Merge Do not merge this PR label Jan 1, 2024
@romanvm romanvm added the Approved Approved and is ready to merge label Jan 1, 2024
@romanvm romanvm merged commit 6d73bd9 into xbmc:matrix Jan 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants