Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script.plexmod] 0.7.9 #2645

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[script.plexmod] 0.7.9 #2645

merged 2 commits into from
Oct 8, 2024

Conversation

pannal
Copy link

@pannal pannal commented Sep 14, 2024

Description

0.7.9, based on 0.7.9-rev3.

0.7.6 -> 0.7.9 commit diff: https://github.com/pannal/plex-for-kodi/compare/v0.7.6...pannal:plex-for-kodi:0.7.9-rev3?expand=1

This adheres to the results of this discussion - we don't write cache settings to advancedsettings.xml if we're installed from the official repository.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@pannal
Copy link
Author

pannal commented Sep 14, 2024

The addon-checker errors relate to https://github.com/xbmc/addon-check/pull/276/files, which has been merged. Why is it still failing? Ah, the new addon checker version hasn't been released, yet.

@romanvm romanvm self-requested a review September 15, 2024 18:39
Copy link
Collaborator

@romanvm romanvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanvm
Copy link
Collaborator

romanvm commented Sep 26, 2024

I'm not sure what to do with addon checker but I will ask other team members.

@romanvm romanvm added the Approved Approved and is ready to merge label Sep 28, 2024
@romanvm
Copy link
Collaborator

romanvm commented Sep 28, 2024

The checker is fixed. If nobody would want to add their second opinion, I'll merge this in a day-two.

@romanvm romanvm merged commit 76c8d06 into xbmc:matrix Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants