-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'nmcli con modify' for nicextraparams on RHEL9 #7444
Conversation
54e749d
to
8ad35b3
Compare
8ad35b3
to
c96e0e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add matching strings for alma9*
and rocky9*
, too.
Furthermore, the configib
script needs similar logic as well.
@Obihoernchen to be clear, when you say similar logic, do you mean using nmcli calls instead of the ifcfg files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some Space/Tab indentation mixup. Can you please fix this? Otherwise it looks good.
Not sure if this is the appropriate place to report this and if this is specific to our site, but this merge breaks infiniband configuration on our Rocky 9 cluster. The error response we got in the script logs for configib is: Digging into this, the IB looks to never have been connected via "nmcli con add " before calls to "nmcli con modify" are made. I modified the configib script after Line 491 to make the following call instead of trying to write an ifcfg-$nic file.
I can possibly work on creating a pull request to address this, but it might take me awhile as I am a bit short on free time. |
Thank you for your report. I'll take a look at it. |
The PR is to address issue #7416
The modification include
add_extra_params_nmcli()
that callsnmcli connection modify
instead of writing to ifcfg files.nmcli con modify
approach for RHEL9 in two places.The UT result
##The UT output##