Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'nmcli con modify' for nicextraparams on RHEL9 #7444

Merged
merged 9 commits into from
Jun 24, 2024

Conversation

alexrichert
Copy link
Contributor

@alexrichert alexrichert commented May 28, 2024

The PR is to address issue #7416

The modification include

  • update to xCAT/postscripts/nicutils.sh to include RHEL9-specific logic in add_extra_params_nmcli() that calls nmcli connection modify instead of writing to ifcfg files.
  • updates configeth postscript to use the nmcli con modify approach for RHEL9 in two places.

The UT result

##The UT output##

@alexrichert alexrichert force-pushed the rhel9_nicextraparams branch from 54e749d to 8ad35b3 Compare May 28, 2024 16:23
@alexrichert alexrichert force-pushed the rhel9_nicextraparams branch from 8ad35b3 to c96e0e3 Compare May 28, 2024 16:24
xCAT/postscripts/configeth Outdated Show resolved Hide resolved
@Obihoernchen Obihoernchen self-assigned this May 29, 2024
@Obihoernchen Obihoernchen added this to the 2.17 milestone Jun 3, 2024
@Obihoernchen Obihoernchen added rh9 all issues for rh9 type:bug labels Jun 3, 2024
@Obihoernchen Obihoernchen mentioned this pull request Jun 3, 2024
7 tasks
Copy link
Member

@Obihoernchen Obihoernchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add matching strings for alma9* and rocky9*, too.

Furthermore, the configib script needs similar logic as well.

@alexrichert
Copy link
Contributor Author

@Obihoernchen to be clear, when you say similar logic, do you mean using nmcli calls instead of the ifcfg files?

@Obihoernchen Obihoernchen marked this pull request as ready for review June 24, 2024 08:56
Copy link
Member

@Obihoernchen Obihoernchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some Space/Tab indentation mixup. Can you please fix this? Otherwise it looks good.

@Obihoernchen Obihoernchen merged commit 1e22382 into xcat2:master Jun 24, 2024
1 check passed
@landcaster
Copy link

Not sure if this is the appropriate place to report this and if this is specific to our site, but this merge breaks infiniband configuration on our Rocky 9 cluster.

The error response we got in the script logs for configib is:
"nmcli Error: unknown connection"

Digging into this, the IB looks to never have been connected via "nmcli con add " before calls to "nmcli con modify" are made.

I modified the configib script after Line 491 to make the following call instead of trying to write an ifcfg-$nic file.

elif [ $OS_name == 'redhat' ]
 then
   # First ip address
   if [ $ipindex -eq 1 ]
     ###
     if [[ "$OSVER" =~ (rhels9|alma9|rocky9) ]]; then
       prefix=$(convert_netmask_to_cidr $netmask)
       nmcli con add type infiniband con-name $nic ifname $nic ipv4.method manual  ipv4.addresses  $nicip/$prefix connection.autoconnect-priority 9
     else 
       ...
     fi
   ....

I can possibly work on creating a pull request to address this, but it might take me awhile as I am a bit short on free time.
As far as how to approach the problem, it is not clear to me if copying the configipv4 and configipv6 function in the configeth script with the appropriate changes would be a good approach to take as I would assume those functions have had extensive work already done to cover many of the cases one would encounter with xcat.

@Obihoernchen
Copy link
Member

Thank you for your report. I'll take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rh9 all issues for rh9 type:bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants