fix: deep-merge with nil args or values

xcoo · Apr 24, 2024 · 917fc94 · 917fc94
1 parent 4571b9d
commit 917fc94
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/cljc/proton/core.cljc b/src/cljc/proton/core.cljc
@@ -198,7 +198,8 @@
   "Recursively merges maps."
   [& maps]
   (letfn [(m [& xs]
-            (if (every? #(and (map? %) (not (record? %))) xs)
-              (apply merge-with m xs)
-              (last xs)))]
+            (let [xs (remove nil? xs)]
+              (if (every? #(and (map? %) (not (record? %))) xs)
+                (apply merge-with m xs)
+                (last xs))))]
     (reduce m maps)))
diff --git a/test/proton/core_test.cljc b/test/proton/core_test.cljc
@@ -158,6 +158,14 @@
     nil 3 7))
 
 (deftest deep-merge-test
+  (is (= (core/deep-merge {:foo 1} nil)
+         {:foo 1}))
+  (is (= (core/deep-merge nil {:foo 1})
+         {:foo 1}))
+  (is (= (core/deep-merge {:foo 1} {:foo nil})
+         {:foo 1}))
+  (is (= (core/deep-merge {:foo nil} {:foo 1})
+         {:foo 1}))
   (is (= (core/deep-merge {:foo {:bar 1}} {:foo {:baz 2}})
          {:foo {:bar 1 :baz 2}}))
   (is (= (core/deep-merge {:foo {:bar 1}} {:baz 2})