lvutil: use wipefs not dd to clear existing signatures (xapi-project#624) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamreis
approved these changes
Jan 11, 2024
stormi
approved these changes
Jan 12, 2024
Wescoeur
reviewed
Jan 12, 2024
drivers/XE_SR_ERRORCODES.xml
Outdated
| @@ -881,6 +881,12 @@ | |||
| <value>460</value> | |||
| </code> | |||
|
|
|||
| <code> | |||
| <name>WipeFS</name> | |||
There was a problem hiding this comment.
WipefsFailure maybe like other errors?
| @@ -881,6 +881,12 @@ | |||
| <value>460</value> | |||
| </code> | |||
|
|
|||
| <code> | |||
| <name>WipeFS</name> | |||
| <description>Failed to wipe pre-existing filesystem signature.</description> | |||
There was a problem hiding this comment.
A lot of descriptions don't have a period at the end. Maybe we need to add a contribution in the upstream repository to standardize this situation.
drivers/util.py
Outdated
| "Wipe filesystem signatures from `blockdev`" | ||
| cmdlist = ["/usr/sbin/wipefs", "-a", blockdev] | ||
| SMlog("Running command: %s" % cmdlist) | ||
| (rc, stdout, stderr) = doexec(cmdlist) |
) Signed-off-by: Yann Dirson <[email protected]>
ydirson
force-pushed
the
3.0.10-wipefs
branch
from
09aa30e
to
a08ad58
Compare
Wescoeur
approved these changes
Jan 17, 2024
stormi
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.