-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for pxe #248
Open
gthvn1
wants to merge
75
commits into
ydi/install
Choose a base branch
from
gtn-pxe
base: ydi/install
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add support for pxe #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault-SR Signed-off-by: Yann Dirson <[email protected]>
Other methods to get SRs return `SR` objects, this was inconsistent. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
"vm-cd-insert" does not mount anything, as the need for a subsequent "mount" in the only test using it shows. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
The entrypoint is ssh(), and the default values are already there. Signed-off-by: Yann Dirson <[email protected]>
Since f9b5365 the VM ctor takes care of reporting this info. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
This will be useful to the plugin that allows not rerunning a cached dependency: it needs to probe the cache. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
When testing in a nested setup, 2 min is not enough to boot a Debian 12 to the point the XS agent has published to xenstore. 5 min should be enough for everyone. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
…nning VM. There is no other inter-test dependency in this file, this allows to stop using @pytest.mark.incremental here. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
Same as for test_basic_without_ssh, and this allows to stop using @pytest.mark.incremental here too. Signed-off-by: Yann Dirson <[email protected]>
Previous commits removed its two only uses, replaced by an autouse fixture. Other possible uses would be covered (with a more fine-grained approach) by pytest-dependency. This frees the global pytest_runtest_makereport hook for potential reuse. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
We will need this value in other places. Signed-off-by: Yann Dirson <[email protected]>
And make the whole easier to copypaste. Signed-off-by: Yann Dirson <[email protected]>
Reported by mypy. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
We want to have it in log-file. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
With install tests the description becomes really long, use chars sparingly. Signed-off-by: Yann Dirson <[email protected]>
The logger setup was confusing when using --log-file-level=DEBUG, showing this debug-level output inside default --log-cli-level=INFO output, but without the debug context that only went into the logfile, and without any hint of what kind of output it was. This makes it use the same logger as all other debug output, preventing it from appearing in the wrong place, and adds a marker to hint it is output data - at the same time fixing a potential formatting issue, where arbitrary ssh output lines were interpreted as *format strings*. Signed-off-by: Yann Dirson <[email protected]>
FIXME: replace with explicit clone naming
If the host's name-label was changed using XO after installation, but the UNIX hostname was not, $HOSTNAME is wrong. Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
ydirson
force-pushed
the
ydi/install
branch
18 times, most recently
from
September 27, 2024 13:58
72f98fa
to
aa4131a
Compare
ydirson
force-pushed
the
ydi/install
branch
11 times, most recently
from
October 10, 2024 08:54
7aef3a1
to
684e334
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.