Add fast xva_bridge.py script #350
Conversation
dinhngtu
force-pushed
the
dnt/fast-xva-bridge
branch
6 times, most recently
from
6428f16 to
c67e179
Compare
| import logging | ||
| from xml.dom import minidom | ||
|
|
||
| import libarchive |
There was a problem hiding this comment.
Should the readme mention this requirement? And/or the whole project's python requirements be updated so that everyone can use the script without having to discover the missing dependency at runtime?
There was a problem hiding this comment.
I wasn't sure about updating the repo-level requirements since it's not part of the tests, so I'll defer to your preference.
There was a problem hiding this comment.
In my opinion, it should be added to the dev dependencies.
uv add --raw 'libarchive-c==5.3'
There was a problem hiding this comment.
What to do with the old get_xva_bridge.sh and set_xva_bridge.sh? (and the readme which mentions them)
There was a problem hiding this comment.
I can update the readme. I think the scripts should stay for now.
There was a problem hiding this comment.
For what reason should they stay? The new script is not a full replacement?
There was a problem hiding this comment.
There's no reason, it's rather just in case someone needs them. I can also delete them, since personally I won't be using the old scripts.
There was a problem hiding this comment.
Deleted. But maybe @gduperrey will have a preference since he's the one using this daily?
dinhngtu
force-pushed
the
dnt/fast-xva-bridge
branch
3 times, most recently
from
e14f860 to
4292c9b
Compare
Signed-off-by: Tu Dinh <[email protected]>
Signed-off-by: Tu Dinh <[email protected]>
dinhngtu
force-pushed
the
dnt/fast-xva-bridge
branch
from
4292c9b to
ea7e39a
Compare
|
Static binary builder using Nuitka is available here: https://github.com/dinhngtu/xva-bridge-builder |
Add a rewritten XVA bridge getter/setter script using libarchive bindings.
This script streams tar members directly instead of using temporary files, and thus processes XVAs faster than the existing shell scripts, without needing additional disk space (beyond that of the new XVA).
It also uses Python's DOM library to guarantee parsing of
ova.xml.Tested on
libarchive-c==5.3. Due to use of library internals, may not work on other versions of libarchive-c.Delete the old bash scripts for XVA editing.