Add coalesce integrity tests on most SR types #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaëtan Lehmann <[email protected]>
So we can use the easier to read `1GiB` size Signed-off-by: Gaëtan Lehmann <[email protected]>
So we have something to write to. 1GiB seems small enough to not impact performance or request all the resources Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
Signed-off-by: Gaëtan Lehmann <[email protected]>
glehmann
changed the title
stormi
reviewed
Oct 2, 2025
|
|
||
|
|
||
| def install_randstream(vm: 'VM'): | ||
| vm.ssh("wget -nv https://github.com/xcp-ng/randstream/releases/download/0.3.1/randstream-0.3.1-x86_64-unknown-linux-musl.tar.gz -O - | tar -xzC /usr/bin/ ./randstream") # noqa: E501 |
There was a problem hiding this comment.
Something we should package instead? It's inside the VM
There was a problem hiding this comment.
We could add it to the Alpine image, but it seems simpler this way
Nambrok
reviewed
Oct 2, 2025
| return self._type | ||
|
|
||
| def create_vdi(self, name_label: str, virtual_size: int = 64, image_format: Optional[str] = None) -> VDI: | ||
| def create_vdi(self, name_label: str, virtual_size: int | str = 64, image_format: Optional[str] = None) -> VDI: |
There was a problem hiding this comment.
I would prefer to choose between int or string. String make sense with how you want to use it 1GiB, so we could replace the default value to be a string and check caller to change them to use a string.
There was a problem hiding this comment.
I would agree if create_vdi() wasn't used in some untyped code. For now, using it this way seems safer in order not to break existing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if others should be covered as well.
I've removed the coalesce tests based on
dom0, because they seemed redundant, but we could also keep them. Just let me know.