Don't check return status from smartctl -a

Some device doesn't support SMART capability and getting information from such device returns an error code 4. As it happens in CI we remove the check of the return code. Signed-off-by: Guillaume <[email protected]>
xcp-ng · Dec 19, 2023 · e6a4c8a · e6a4c8a
1 parent e9415e0
commit e6a4c8a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/SOURCES/etc/xapi.d/plugins/smartctl.py b/SOURCES/etc/xapi.d/plugins/smartctl.py
@@ -24,7 +24,7 @@ def get_information(session, args):
     with OperationLocker():
         disks = _list_disks()
         for disk in disks:
-            cmd = run_command(["smartctl", "-j", "-a", disk])
+            cmd = run_command(["smartctl", "-j", "-a", disk], check=False)
             results[disk] = json.loads(cmd['stdout'])
         return json.dumps(results)