Report code coverage #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yann Dirson <[email protected]>
While not necessary for the OS image in use for the test, it helps in documenting the need for a non-default lib. Signed-off-by: Yann Dirson <[email protected]>
Calling from toplevel provides more streamlined workflow (eg. when locally running for coverage) Signed-off-by: Yann Dirson <[email protected]>
Signed-off-by: Yann Dirson <[email protected]>
We don't do anything with it yet, aside from displaying the report Signed-off-by: Yann Dirson <[email protected]>
benjamreis
reviewed
Jul 6, 2022
| if [ -f requirements.txt ]; then pip install -r requirements.txt; fi | ||
| - name: pytest | ||
| run: | | ||
| cd tests |
There was a problem hiding this comment.
the cd tests is no longer required?
There was a problem hiding this comment.
As I understand it, it is essentially useful to restrict test discovery, which can be done as well on pytest commandline (though this is not even necessary, there is just no other tests to be discovered in other dirs).
OTOH it requires a .coveragerc to be under tests/ as well, which means a dev has to use this cd tests in everyday life as well.
There was a problem hiding this comment.
The cd tests is related to this issue: pytest-dev/pyfakefs#666
It's merged for several months, in theory we can remove this instruction if we use the latest version of pyfakefs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.