scripts: Add upload_bugtool.py #715
Conversation
|
|
||
| args = parser.parse_args() | ||
|
|
||
| if any("://" in file for file in args.files): |
There was a problem hiding this comment.
os.path.exists() could be a more useful check?
There was a problem hiding this comment.
I'm not consuming the file directly so I prefer to let curl do the check.
There was a problem hiding this comment.
Well, I'm not convinced :) I don't see the value introducing a partial check where we could have a full one for less code volume.
dinhngtu
force-pushed
the
dnt/upload-bugtool
branch
from
cf93034 to
631c30a
Compare
Signed-off-by: Tu Dinh <[email protected]>
dinhngtu
force-pushed
the
dnt/upload-bugtool
branch
from
631c30a to
ecfb82e
Compare
| def version_lt(a, b): | ||
| for ai, bi in zip_longest(a, b, fillvalue=0): | ||
| if ai < bi: | ||
| return True | ||
| elif ai > bi: | ||
| return False | ||
| return False |
There was a problem hiding this comment.
Why do we need this? Isn't this just a reimplementation of sequence comparison?
| try: | ||
| subprocess.check_call(curl_args, stdout=sys.stdout, stderr=sys.stderr) | ||
| except: | ||
| print("curl failed, see output above.", file=sys.stderr) | ||
| sys.exit(1) |
There was a problem hiding this comment.
A failure to execute curl (missing, corrupted...) will show nothing in "output above". Silencing exceptions is considered harmful.
|
|
||
| args = parser.parse_args() | ||
|
|
||
| if any("://" in file for file in args.files): |
There was a problem hiding this comment.
Well, I'm not convinced :) I don't see the value introducing a partial check where we could have a full one for less code volume.
Add a hybrid py2/py3 script for uploading bugtool archives to Nextcloud via a drop link.