Do not assume IPv4 when disabling management

Instead look at the inventory to decide the address type, this will avoid to override the value in the inventory when its rewritten Signed-off-by: Benjamin Reis <[email protected]>
xcp-ng · Sep 24, 2024 · e9e26e1 · e9e26e1
1 parent 9bfcc40
commit e9e26e1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/ocaml/xapi/xapi_host.ml b/ocaml/xapi/xapi_host.ml
@@ -1303,7 +1303,11 @@ let management_disable ~__context =
     raise
       (Api_errors.Server_error (Api_errors.slave_requires_management_iface, [])) ;
   (* Reset the management server *)
-  Xapi_mgmt_iface.change "" `IPv4 ;
+  let management_address_type =
+    Record_util.primary_address_type_of_string
+      (Xapi_inventory.lookup Xapi_inventory._management_address_type)
+  in
+  Xapi_mgmt_iface.change "" management_address_type ;
   Xapi_mgmt_iface.run ~__context ~mgmt_enabled:false () ;
   (* Make sure all my PIFs are marked appropriately *)
   Xapi_pif.update_management_flags ~__context