Bring back DLL dependencies instead of bundling NuGet packages. #237
+13
−22,712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Report Viewer DLL dependencies to 12.0.2402.15. Generate MSTSC dependency at build time. Signed-off-by: Tu Dinh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Report Viewer DLL dependencies to 12.0.2402.15. Generate MSTSC dependency at build time.
Setting package path in project file does not work on Visual Studio if the packages aren't already installed or the NuGet package sources are not set manually. In addition, we don't control the package names on NuGet, and the Microsoft.ReportViewer package is no longer maintained. This brings a significant security risk.
Report Viewer DLL dependencies have been updated to 12.0.2402.15, taken from the Microsoft Report Viewer 2015 runtime package.
Instead of bundling MSTSCLib into the project, generate it before building using AxImp.exe. In addition, as AxMSTSCLib is not directly modified, generate it as DLL as well.