fix: issue with invalid characters in downloaded filenames (#23)

xdamman · May 18, 2019 · b8b6cd2 · b8b6cd2
1 parent e423dbe
commit b8b6cd2
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 2 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -1,5 +1,6 @@
 const r2 = require('r2')
 const fs = require('fs')
+const sanitize = require('sanitize-filename')
 
 const MEDIUM_IMG_CDN = 'https://cdn-images-1.medium.com/max/'
 let mentionedUsers = []
@@ -8,7 +9,7 @@ async function downloadImages(images, options = {}) {
   const articleImages = []
 
   for (const image of images) {
-    let file = image.split('/')[image.split('/').length - 1]
+    let file = sanitize(image.split('/')[image.split('/').length - 1])
 
     if (options.featuredImage && options.featuredImage === file) {
       let type = file.split('.')[file.split('.').length - 1]

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -15,7 +15,8 @@
     "commander": "^2.19.0",
     "r2": "^2.0.1",
     "rss-parser": "^3.6.2",
-    "underscore.string": "^3.3.5"
+    "underscore.string": "^3.3.5",
+    "sanitize-filename": "^1.6.1"
   },
   "devDependencies": {
     "codecov": "^3.1.0",