Phorm->open() attributes support added #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pejs) for real-time and client-side validation (example updated).
…ue is not an array; it may simply have received no input.
…y the OptionsField subclass.
…is for CheckboxWidgets. But it'd probably be better to have a single OptionsField and choose between radio and checkbox widgets at instantiation.
- Little API changes (use PhormValidation::Required instead of a callback function for required fields) - Little speed inprovements - Better integration of live (javascript) validation. - Add support for translations - W3C validation passed - Better html indentation - Add Phorm::display() to display a complete form - Merge of Phorm and PhormExt, please use Phorm (class name) now - Bug fixes
…efault, or optionally an OptionGroupWidget with RadioWidgets or CheckboxWidgets if specified.
…lean_data method, add get_raw_value (for post-validate to get access to values that haven't made available yet -- yuck!), and move error gathering and value gathering directly into their respective functions.
Removed Javascript files, its gonna happen later when an Ajax way is introduced in parallel with the proper server-side way. Removed docs (regenerate later when everything is smooth). Removed extra examples and classes. Splitted classes to files. Unified loading of classes. Started implementing filter_var wherever possible. Fixed a lot of PHPDoc comments. Signed-off-by: Petsagourakis George <[email protected]>
…nteger", added $size param to Decimal and Integer fields, simplified built-in 'required' validation, changed default form method from GET to POST, added display_errors() function to output ALL error messages, and added a public fields() function to expose all form field objects for looping. Added a new example file, and cleaned up some code and comments.
… built-in _required_ validation code
…f "required" validator.
add validate_required_field: checks if checkbox is checked in case of "required" validator.
add further checks in file_was_uploaded
Checkbox Bug
- added missing parameters to Hidden#label() and Hidden#help_text() to match superclass signatures
- value was html-escaped twice in this function, resulting in broken forms
- added explicit check for 0 to circumvent cast to false
Small bugfixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phorm->open() did not make use of its attributes argument, this can now be used to add to the attributes applied and overwrite existing, should be backwards compatible.